Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix lingering demo-data source issues #6659

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix(ingest): fix lingering demo-data source issues #6659

merged 1 commit into from
Dec 6, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 6, 2022 •
edited
Loading

  • renames dummy-data -> demo-data
  • makes the config empty

Follow up on #6550.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(ingest): fix lingering demo-data source issues
910a827 
- renames dummy-data -> demo-data
- makes the config empty
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 4m 24s ⏱️ + 1m 27s
   767 tests ±0     765 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 536 runs  ±0  1 531 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 910a827. ± Comparison against base commit 43c566e.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   16m 6s ⏱️ +27s
158 suites ±0       4 💤 ±0 
158 files   ±0       0 ❌ ±0 

Results for commit 910a827. ± Comparison against base commit 43c566e.

@hsheth2 hsheth2 merged commit 71bfa98 into datahub-project:master Dec 6, 2022
@hsheth2 hsheth2 deleted the demo-data branch December 6, 2022 21:10
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): fix lingering demo-data source issues (datahub-project#6659
1a037d7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @anshbansal